Antville Project

topics or link macro broken?

say, do you see only "about antville" links in this topic, too? or is it just me? i think it should be "download" or whatever and link to somewhere else but the disclaimer... weird. what happen? somebody set up us the bomb?

comment    

 
robert, March 28, 2002 at 11:46:30 AM CET

that's one of the funniest bugs i've seen lately ;-)) unfortunately i have to leave now for two hours or so, can you have a look what's wrong? since the story looks fine, i assume there's a parent-problem or the like ...

link  

 
tobi, March 28, 2002 at 1:26:51 PM CET

was out for lunch myself, but will now take a look and do my best... :)

link  


... comment
 
hns, March 28, 2002 at 1:36:17 PM CET

I saw the same thing yesterday

After I saved the story the problem went and the story displayed as it should (just like it does right now) but obviously it's a recurring problem.

link  

 
tobi, March 28, 2002 at 1:43:54 PM CET

yes, links in new stories appear ok, and those in old stories become "repaired" after saving them again. still diggin'.

link  


... comment
 
hns, March 28, 2002 at 1:43:33 PM CET

OK, I think I know what the problem is

link_macro in global/macros.js goes like this:

path[path.length-1].link_macro(param);

But if this is called for a story within a topic and the story's main action is invoked, link_macro is called on the topic object instead of the weblog object, and link_macro in the topic object renders a link to the topic.

The right thing to do in the global link macro would be

if (path.weblog) path weblog.link_macro (param); else root.link_macro (param);

(right? not 100% sure about that, but if I get it right, that's what the code tries to do.)

link  

 
hns, March 28, 2002 at 1:46:24 PM CET

Wait, that's bullshit

the topic prototype doesn't even have a link_macro function defined...

link  

 
tobi, March 28, 2002 at 1:46:25 PM CET

does this explain why it works after saving such a corrupted story? i also created a new topic with a link and it appeared to be ok...

link  

 
tobi, March 28, 2002 at 1:48:34 PM CET

ad link_macro in topic

oh yes, it has: every hopobject has due to hopobject/macros.js...

link  

 
hns, March 28, 2002 at 1:54:42 PM CET

I can reproduce it now

It happens when a link macro is rendered when viewing a topic, i.e. when the link macro is called on the topicmanager topic.

link  

 
tobi, March 28, 2002 at 1:58:14 PM CET

where?

can you please give an example, i just can't find any mad link desease right now...

link  

 
hns, March 28, 2002 at 2:00:04 PM CET

It's easier when run your own antville server

  1. create a story within a topic that contains a link macro
  2. restart Helma (or flush the cache)
  3. view the topic which contains the story with the link macro.

link  

 
hns, March 28, 2002 at 2:07:18 PM CET

OK, now I have it (really this time)

the day prototype overwrites the link_macro function to link to itself, and when viewing a day or a topic, the link_macro in day or topic is called instead of the one defined in hopobject.

The real issue here is that this is a OO design error. link_macro should not be in hopobject, because it's not a function on hopobjects. it's a global function. So the work to create a link should best be done right in the global link_macro function.

I think this is a problem that occurs in some places in Antville, and should be refactored eventually. E.g., function isStoryOnline in prototype weblog should be refactored as function isOnline in prototype story.

link  

 
robert, March 28, 2002 at 3:47:28 PM CET

oh oh

just came back. yes henso, your're right: there are some design errors in antville that cry for fixing. i think it's time to clean up the code.

link  

 
hns, March 28, 2002 at 3:56:05 PM CET

It's not that bad

but it's good to always keep improving (which I should be doing now for Helma, where things are much worse ;-)

link  

 
robert, March 28, 2002 at 4:01:17 PM CET

i hope it's not that bad, but

design errors hurt more than simple bugs ;-) anyway, i think now is a good time for cleanup before the next (big) features are implemented ....

link  

 
hns, March 28, 2002 at 5:49:54 PM CET

nope

design errors are a necessity of doing anything! If they'd hurt, I'd be dead by now.

link  


... comment


The Antville Server Fund has been a great success. Thanks to everybody who contributed!
online for 8550 Days
last updated: 1/4/11, 10:22 AM
status
Youre not logged in ... Login
menu
November 2024
SunMonTueWedThuFriSat
12
3456789
10111213141516
17181920212223
24252627282930
July
recent
zfuture's house here is zfuture's
house
by zfuture (7/31/03, 2:59 AM)
i understand your concerns however,
i hardly can think of a solution. certainly, if the...
by tobi (7/29/03, 9:47 AM)
Found several more similar sites
listed This is getting to be quite a concern to...
by cobalt123 (7/27/03, 7:56 PM)
Second Post Alert on Referrer
bug livecatz I put this into "help" and now here:...
by cobalt123 (7/26/03, 7:14 PM)
well it's not easy to
find from here, anyway. think we should include a link,...
by tobi (7/24/03, 11:25 AM)
So finally I found
the helma Bugzilla - stupid me.
by mdornseif (7/24/03, 10:28 AM)
clock not that it's particularly
earthshattering but the antclock is running slow by about 15...
by kohlehydrat (7/23/03, 8:25 PM)
but blogosphere.us isn't can't really
be rated as spam can it?
by kohlehydrat (7/23/03, 8:08 PM)
More referrer spam www.webfrost.com
by Irene (7/23/03, 7:55 PM)
How to log skin names
I accessed to console?? Hi, I would like to know...
by winson (7/23/03, 4:12 PM)

Click here to get an XML version of this weblog.

Made with Antville
powered by
Helma Object Publisher